Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-chart-echarts): upgrade to echarts 5.4.1 #22382

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

villebro
Copy link
Member

@villebro villebro commented Dec 10, 2022

SUMMARY

Bump ECharts to 5.4.1. Changelog: https://echarts.apache.org/en/changelog.html

More specifically for Superset, this patch release fixes an issue that @zhaoyongjie spotted in this review commen: #22218 (comment) (link to original fix PR: apache/echarts#17715)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@zhaoyongjie Ephemeral environment spinning up at http://35.93.30.108:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM. Thanks for the fixing.

@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #22382 (c483904) into master (368e7e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22382   +/-   ##
=======================================
  Coverage   66.86%   66.86%           
=======================================
  Files        1847     1847           
  Lines       70567    70567           
  Branches     7744     7744           
=======================================
  Hits        47184    47184           
  Misses      21382    21382           
  Partials     2001     2001           
Flag Coverage Δ
javascript 53.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro villebro merged commit 6b4ab8a into apache:master Dec 10, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants