-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change type of slack error #22443
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22443 +/- ##
===========================================
- Coverage 66.86% 55.56% -11.31%
===========================================
Files 1847 1850 +3
Lines 70574 70699 +125
Branches 7748 7750 +2
===========================================
- Hits 47190 39283 -7907
- Misses 21383 29400 +8017
- Partials 2001 2016 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
f6b9b31
to
d069cb5
Compare
d069cb5
to
4831a83
Compare
🏷️ preset:2023.01 |
(cherry picked from commit 7591acb)
SUMMARY
Small change to log a 400 error if there are slack api errors caught. Also fixes a parsing error in the exception handling where we were trying to parse an exception as a string.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION