Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): Overflow bigint in json-tree view #22609

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

justinpark
Copy link
Member

SUMMARY

The json explore view in sqllab is displaying incorrect values which seemed to be due to Javascript's max integer on 64 bit IDs.
This commit updates the JSON.parser by JSONBig parser as well as custom rendering logic to trim the unnecessary quote format in a bigint string format.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • Before
before--bigint-in-json-tree.mov
  • After
after--bigint-in-json-tree.mov

TESTING INSTRUCTIONS

specs are added

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@ktmud cc: @john-bodley

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #22609 (157ac14) into master (82b0c23) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master   #22609   +/-   ##
=======================================
  Coverage   55.91%   55.91%           
=======================================
  Files        1859     1859           
  Lines       71019    71022    +3     
  Branches     7766     7767    +1     
=======================================
+ Hits        39710    39713    +3     
  Misses      29287    29287           
  Partials     2022     2022           
Flag Coverage Δ
javascript 53.86% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/components/FilterableTable/index.tsx 73.11% <75.00%> (+0.44%) ⬆️
...tend/plugins/legacy-plugin-chart-rose/src/index.js 66.66% <0.00%> (ø)
...nd/plugins/plugin-chart-echarts/src/Gauge/index.ts 50.00% <0.00%> (ø)
...nd/plugins/plugin-chart-echarts/src/Graph/index.ts 50.00% <0.00%> (ø)
...nd/plugins/plugin-chart-echarts/src/Radar/index.ts 50.00% <0.00%> (ø)
...d/plugins/plugin-chart-echarts/src/Funnel/index.ts 50.00% <0.00%> (ø)
...lugins/legacy-plugin-chart-event-flow/src/index.ts 50.00% <0.00%> (ø)
...lugins/plugin-chart-handlebars/src/plugin/index.ts 66.66% <0.00%> (ø)
...c/visualizations/FilterBox/FilterBoxChartPlugin.js 66.66% <0.00%> (ø)
...ins/legacy-preset-chart-nvd3/src/DualLine/index.js 66.66% <0.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas merged commit a8f3a4f into apache:master Jan 11, 2023
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Jan 23, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants