-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Report screenshot cut off on left and right sides #22614
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22614 +/- ##
==========================================
+ Coverage 67.00% 67.03% +0.03%
==========================================
Files 1859 1859
Lines 71036 71037 +1
Branches 7766 7767 +1
==========================================
+ Hits 47597 47623 +26
+ Misses 21417 21386 -31
- Partials 2022 2028 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
@eschutho Ephemeral environment spinning up at http://54.185.134.130:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
@lyndsiWilliams I believe this PR has caused a regression for dashboard thumbnails. When rendering dashboard thumbnails, I'm now getting the following timeout error:
In this PR we're assuming that dashboards are always being rendered with the superset/superset/reports/commands/execute.py Lines 189 to 196 in 3e07de7
Contrast that with dashboard thumbnails (notice the missing standalone kwarg): superset/superset/tasks/thumbnails.py Line 85 in 3e07de7
It might be a good idea to create a util for generating the chart and dashboard URLs to ensure we're always using the same logic for alerts, reports and thumbs. Thoughts? |
Thanks for catching this error @villebro! I took your suggestion in #23003 and wound up moving the standalone logic closer to the screenshot classes that define the element to capture. I'd love to get your thoughts on that approach. |
SUMMARY
This PR fixes report screenshot width. Screenshots were being cut off on the left and right. I fixed this by having the screenshot capture by class
standalone
and removing the filter bar whenstandalone=3
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION