Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Swapping main superset images for more current versions #22668

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

rusackas
Copy link
Member

SUMMARY

This just swaps out a few of the Supserset screenshots on the home page at https://superset.apache.org/. I tried to find decent shots of stock dashboards. They might not be the most whiz-bang examples, but are SO much more current, so the UI looks fresh.

More updates to the home page will probably follow over time... trying to keep things bite size!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

cd docs
yarn install  # Installs NPM dependencies
yarn start  # Starts development server at http://localhost:3000

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #22668 (bc22f1d) into master (73e53fa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22668   +/-   ##
=======================================
  Coverage   67.10%   67.10%           
=======================================
  Files        1869     1869           
  Lines       71580    71580           
  Branches     7806     7806           
=======================================
  Hits        48031    48031           
  Misses      21521    21521           
  Partials     2028     2028           
Flag Coverage Δ
hive 52.60% <ø> (ø)
javascript 53.96% <ø> (ø)
mysql 78.01% <ø> (ø)
postgres 78.08% <ø> (ø)
presto 52.49% <ø> (ø)
python 81.31% <ø> (ø)
sqlite 76.48% <ø> (ø)
unit 51.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas changed the title Chore: Swapping main superset images for more current versions chore: Swapping main superset images for more current versions Jan 11, 2023
@rusackas rusackas requested a review from a team January 12, 2023 17:29
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better!

@rusackas rusackas merged commit ce1fa95 into master Jan 12, 2023
@rusackas rusackas deleted the swapping-main-superset-images branch January 30, 2023 18:55
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants