chore(ci): fix numpy type errors and revert #22610 #22782
Conversation
| if df.dtypes[column] == np.object: | ||
| if df.dtypes[column] == np.object_: |
There was a problem hiding this comment.
Nowadays np.object is the same as object:
>>> import numpy as np
>>> np.object
<stdin>:1: DeprecationWarning: `np.object` is a deprecated alias for the builtin `object`. To silence this warning, use `object` by itself. Doing this will not modify any behavior and is safe.
Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
<class 'object'>I'm opting for np.object_ here as it seems cleaner and it also worked (there's a unit test for this, so we'll catch this if it changes in the future). Check https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations 👍
| result = np.copy(array) | ||
|
|
||
| with np.nditer(result, flags=["refs_ok"], op_flags=["readwrite"]) as it: | ||
| with np.nditer(result, flags=["refs_ok"], op_flags=[["readwrite"]]) as it: |
There was a problem hiding this comment.
Wow, this actually caught an incorrect type!
villebro
force-pushed
the
villebro/numpy-lint
branch
from
bc8fb4f
to
d6fd474
Compare
| description-file = README.md | ||
| description_file = README.md | ||
| author = Apache Superset Dev | ||
| author-email = dev@superset.apache.org | ||
| author_email = dev@superset.apache.org |
There was a problem hiding this comment.
Bycatch; noticed this was being emitted by pylint:
/Users/ville/apple/apache-superset/.tox/pylint/lib/python3.8/site-packages/setuptools/dist.py:770: UserWarning: Usage of dash-separated 'description-file' will not be supported in future versions. Please use the underscore name 'description_file' instead
warnings.warn(
/Users/ville/apple/apache-superset/.tox/pylint/lib/python3.8/site-packages/setuptools/dist.py:770: UserWarning: Usage of dash-separated 'author-email' will not be supported in future versions. Please use the underscore name 'author_email' instead
Codecov Report
@@ Coverage Diff @@
## master #22782 +/- ##
===========================================
- Coverage 67.27% 55.99% -11.29%
===========================================
Files 1875 1876 +1
Lines 71820 71880 +60
Branches 7870 7867 -3
===========================================
- Hits 48319 40246 -8073
- Misses 21473 29607 +8134
+ Partials 2028 2027 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
villebro
force-pushed
the
villebro/numpy-lint
branch
from
583c4cd
to
5bdbdac
Compare
This reverts commit c87f654.
villebro
changed the title
villebro
changed the title
| dev = request.args.get("testing") | ||
| if dev is not None: | ||
| return super().render_app_template() | ||
| return redirect("/") |
There was a problem hiding this comment.
This is from the revert, not my change
There was a problem hiding this comment.
I checked blame, the original code is from this PR: #20869
mistercrunch
added
🏷️ bot
SUMMARY
Fix recently introduced typing errors that are blocking CI:
In addition, revert #22610, as it broke SQL Lab. Without the revert, SQL Lab loads without the top nav:
With the revert, SQL Lab loads properly again:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION