-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Gauge echart): displaying column label #23396
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23396 +/- ##
===========================================
+ Coverage 56.27% 67.71% +11.44%
===========================================
Files 1907 1918 +11
Lines 73495 74157 +662
Branches 7977 8053 +76
===========================================
+ Hits 41356 50219 +8863
+ Misses 30091 21885 -8206
- Partials 2048 2053 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 372 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@sfirke could you please review this pr! |
@AkashBoora I don't have any permissions on this repository, I just comment and try to help things along. I also don't know most of the codebase. You could try posting in the #contributing channel in the Slack chat asking for a review on this. Looks like a good PR to me though and I'm grateful that you're improving Superset 🙏 |
@villebro could you please review this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check what happens if you don't have a verbose name defined for your column? I believe my change should address this edge case.
superset-frontend/plugins/plugin-chart-echarts/src/Gauge/transformProps.ts
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-echarts/src/Gauge/transformProps.ts
Outdated
Show resolved
Hide resolved
…formProps.ts Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
…formProps.ts Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
hello @villebro , yeah the edge case which you have mentioned may not covered by my code. thanks for correcting me :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AkashBoora functional changes look good, but I believe there's some linting issues that need to be fixed. |
SUMMARY
Changed logic to display the label of field/column. Earlier it was showing field name.
For one dataset i gave label to column 'name', but it was not reflecting in chart. But now the label name is refecting in the chart
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION