feat(helm): add nodeselector and tolerations to init job #23416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dim-ops
requested review from
craig-rueda,
dpgaspar and
villebro
as code owners
dim-ops
force-pushed
the
feat/helm-add-nodeselector-and-tolerations-to-init-job
branch
from
62c7161
to
4111d28
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nytai
reviewed
Mar 20, 2023
dim-ops
force-pushed
the
feat/helm-add-nodeselector-and-tolerations-to-init-job
branch
from
4111d28
to
791a567
Compare
craig-rueda
reviewed
Mar 21, 2023
dim-ops
requested review from
craig-rueda and
nytai
and removed request for
nytai and
craig-rueda
dim-ops
force-pushed
the
feat/helm-add-nodeselector-and-tolerations-to-init-job
branch
from
14288fa
to
304dbc2
Compare
dim-ops
force-pushed
the
feat/helm-add-nodeselector-and-tolerations-to-init-job
branch
from
304dbc2
to
ec324c2
Compare
|
@craig-rueda is it possible to merge ? Because I fixed my code because which was in conflict with #23452 which you approved and merged while mine is more complete. |
craig-rueda
approved these changes
Mar 24, 2023
|
Hi, I setup: but it applies only for superset and worker. Redis and Postgresql with out node-selector. How to fix that? |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add nodeselector and tolerations to init job for this issue: #23109