Fix for Python 2/3 compatibility #2342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 2 calling keys makes a copy of the key that you can iterate over while modifying the dict. This doesn't work in Python 3, because keys returns an iterator instead of a list. To make it work in both Python 2 and 3, use `list(d)` instead of d.keys() to force a copy. Source: http://stackoverflow.com/a/11941855
|
Not sure if this is related to #2317 as the issue does not specify the Python version, but I picked up this issue when trying to migrate from 0.15.4 to 0.17.0. I'll create a seperate issue and link to this pull request. |
3 tasks
|
Dup of #2320 |
|
Ha, thanks! Maybe I should rather create a pull request to remind users to check both issues and pull requests in the |
|
@jr-minnaar PR clashes are not so frequest and people tend to put already checks randomly in the issue template that i won't bother doing so :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 2 calling keys makes a copy of the key that you can iterate over while modifying the dict.
This doesn't work in Python 3, because keys returns an iterator instead of a list.
To make it work in both Python 2 and 3, use
list(d)instead of d.keys() to force a copy.Source: http://stackoverflow.com/a/11941855