Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DB engine spec): get_catalog_names #23447

Merged
merged 2 commits into from
Mar 22, 2023
Merged

feat(DB engine spec): get_catalog_names #23447

merged 2 commits into from
Mar 22, 2023

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Mar 21, 2023

SUMMARY

Add a method get_catalog_names to the base DB engine spec, and implement it in Postgres as a reference.

This supports #22862. Right now it's not used anywhere, but it's needed in order to implement a hook for generating catalog-level permissions.

Next step is implementing get_catalog_names in more DB engine specs:

  • BigQuery
  • Drill
  • Snowflake
  • Trino
  • ?

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida changed the title feat (DB engine spec): get_catalog_names feat(DB engine spec): get_catalog_names Mar 21, 2023
@betodealmeida betodealmeida force-pushed the list_catalogs branch 3 times, most recently from 008d790 to 0f5107c Compare March 21, 2023 22:23
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #23447 (64d9622) into master (226b60b) will increase coverage by 0.00%.
The diff coverage is 88.88%.

@@           Coverage Diff           @@
##           master   #23447   +/-   ##
=======================================
  Coverage   67.63%   67.63%           
=======================================
  Files        1908     1908           
  Lines       73729    73738    +9     
  Branches     7989     7989           
=======================================
+ Hits        49867    49875    +8     
- Misses      21814    21815    +1     
  Partials     2048     2048           
Flag Coverage Δ
hive 52.73% <77.77%> (+<0.01%) ⬆️
javascript 53.82% <ø> (ø)
mysql 78.44% <77.77%> (-0.01%) ⬇️
postgres 78.50% <88.88%> (+<0.01%) ⬆️
presto 52.66% <77.77%> (+<0.01%) ⬆️
python 82.36% <88.88%> (+<0.01%) ⬆️
sqlite 77.01% <77.77%> (+<0.01%) ⬆️
unit 52.59% <77.77%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/base.py 90.86% <80.00%> (-0.09%) ⬇️
superset/db_engine_specs/postgres.py 97.10% <100.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro
Copy link
Member

This is exciting stuff! 🤩

@betodealmeida betodealmeida merged commit 8588f81 into master Mar 22, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the list_catalogs branch March 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants