fix(plugin-chart-table): Invalid d3Formatter on String column #23515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
regression from #17336
column_config applied the
d3NumberFormat
to all columns including STRING column, the string column value has been converted to 'NaN' due to invalid formatter.When dnd column is disabled, there's no option to customize the format for a column.
This commit replaces
numberFormat
to apply for Number column only.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
Before:
TESTING INSTRUCTIONS
Create a Table chart and apply the
d3NumberFormat
ADDITIONAL INFORMATION
cc: @ktmud @michael-s-molina