Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pivot v2 charts created before GENERIC_CHART_AXES is enabled #23731

Merged
merged 6 commits into from
Apr 26, 2023

Conversation

betodealmeida
Copy link
Member

SUMMARY

Pivot v2 charts lose their time granularity when GENERIC_CHART_AXES is enabled, see screenshots.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before, a dashboard showing two pivot charts with monthly time grain, with GENERIC_CHART_AXES enabled. The one on the left was created before GENERIC_CHART_AXES was enabled, and the one on the right was created after. Note that the left chart has multiple values for January, which shouldn't happen:

Screenshot 2023-04-18 at 16-41-16 pivot test

After:

Screenshot 2023-04-18 at 16-41-42 pivot test

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #23731 (2122bd4) into master (e8121b1) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 2122bd4 differs from pull request most recent head 19bff5f. Consider uploading reports for the commit 19bff5f to get more accurate results

@@           Coverage Diff           @@
##           master   #23731   +/-   ##
=======================================
  Coverage   68.02%   68.02%           
=======================================
  Files        1936     1936           
  Lines       74929    74929           
  Branches     8141     8141           
=======================================
+ Hits        50970    50974    +4     
+ Misses      21871    21870    -1     
+ Partials     2088     2085    -3     
Flag Coverage Δ
javascript 54.29% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../plugin-chart-pivot-table/src/plugin/buildQuery.ts 71.42% <ø> (+28.57%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@betodealmeida betodealmeida force-pushed the fix_generic_axis branch 3 times, most recently from 86f543f to 4efecac Compare April 19, 2023 01:59
@pull-request-size pull-request-size bot added size/M and removed size/L labels Apr 19, 2023
@betodealmeida betodealmeida force-pushed the fix_generic_axis branch 4 times, most recently from 261a603 to 84227ec Compare April 24, 2023 20:07
@betodealmeida betodealmeida merged commit 314987f into master Apr 26, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
mostafa-k-m pushed a commit to sylndr/superset that referenced this pull request Dec 6, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the fix_generic_axis branch March 26, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants