-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pivot v2 charts created before GENERIC_CHART_AXES
is enabled
#23731
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23731 +/- ##
=======================================
Coverage 68.02% 68.02%
=======================================
Files 1936 1936
Lines 74929 74929
Branches 8141 8141
=======================================
+ Hits 50970 50974 +4
+ Misses 21871 21870 -1
+ Partials 2088 2085 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
86f543f
to
4efecac
Compare
superset-frontend/packages/superset-ui-core/src/query/buildQueryContext.ts
Outdated
Show resolved
Hide resolved
superset-frontend/packages/superset-ui-core/test/query/buildQueryContext.test.ts
Outdated
Show resolved
Hide resolved
261a603
to
84227ec
Compare
84227ec
to
19bff5f
Compare
SUMMARY
Pivot v2 charts lose their time granularity when
GENERIC_CHART_AXES
is enabled, see screenshots.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before, a dashboard showing two pivot charts with monthly time grain, with
GENERIC_CHART_AXES
enabled. The one on the left was created beforeGENERIC_CHART_AXES
was enabled, and the one on the right was created after. Note that the left chart has multiple values for January, which shouldn't happen:After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION