Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide FiltersPanel in standalone mode 3 #23811

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

geido
Copy link
Member

@geido geido commented Apr 25, 2023

SUMMARY

This PR #23543 fixed an issue for which reports would have to render but not display. However, it failed to hide the FiltersPanel (wrapper of the vertical FilterBar) that gets a fixed width and shows as a blank space in reports.

BEFORE

Clipboard 2023-17-03 at 12 05 28 PM

TESTING INSTRUCTIONS

  1. Visit a Dashboard with existing filters
  2. Enter reports standalone mode with standalone=3 in the url
  3. Make sure the Dashboard loads while the FilterBar is hidden fully and there is no blank space

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #23811 (346ea0d) into master (60c2e70) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 346ea0d differs from pull request most recent head c7b20ce. Consider uploading reports for the commit c7b20ce to get more accurate results

@@            Coverage Diff             @@
##           master   #23811      +/-   ##
==========================================
- Coverage   67.91%   67.91%   -0.01%     
==========================================
  Files        1936     1936              
  Lines       74929    74930       +1     
  Branches     8141     8141              
==========================================
  Hits        50886    50886              
  Misses      21955    21955              
- Partials     2088     2089       +1     
Flag Coverage Δ
javascript 54.28% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...board/components/nativeFilters/FilterBar/index.tsx 50.53% <ø> (ø)
...d/components/DashboardBuilder/DashboardBuilder.tsx 73.26% <50.00%> (-0.74%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 8a88ab3 into master Apr 26, 2023
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Apr 27, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the fix/dashboard-report-empty-space branch March 26, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2023.17 size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants