-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Hide FiltersPanel in standalone mode 3 #23811
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23811 +/- ##
==========================================
- Coverage 67.91% 67.91% -0.01%
==========================================
Files 1936 1936
Lines 74929 74930 +1
Branches 8141 8141
==========================================
Hits 50886 50886
Misses 21955 21955
- Partials 2088 2089 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…dashboard-report-empty-space
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 8a88ab3)
SUMMARY
This PR #23543 fixed an issue for which reports would have to render but not display. However, it failed to hide the FiltersPanel (wrapper of the vertical FilterBar) that gets a fixed width and shows as a blank space in reports.
BEFORE
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION