Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade Cypress to 10.11.0 #23813

Merged
merged 6 commits into from
Apr 26, 2023

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Apr 25, 2023

SUMMARY

Cypress 10.2.0 is the earliest Cypress version that natively supports Apple Silicon. Almost all changes in this PR were done automatically by Cypress's migration tool and the tests are still working just like in our old v7.0.0 without changes.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje changed the title chore: Upgrade Cypress to 10.2.0 chore: Upgrade Cypress to 10.11.0 Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #23813 (8f41a5a) into master (7e4be7d) will increase coverage by 0.02%.
The diff coverage is 66.66%.

❗ Current head 8f41a5a differs from pull request most recent head aa7940c. Consider uploading reports for the commit aa7940c to get more accurate results

@@            Coverage Diff             @@
##           master   #23813      +/-   ##
==========================================
+ Coverage   68.00%   68.02%   +0.02%     
==========================================
  Files        1936     1936              
  Lines       74929    74930       +1     
  Branches     8141     8141              
==========================================
+ Hits        50955    50974      +19     
+ Misses      21886    21870      -16     
+ Partials     2088     2086       -2     
Flag Coverage Δ
javascript 54.29% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../plugin-chart-pivot-table/src/plugin/buildQuery.ts 71.42% <ø> (+28.57%) ⬆️
...board/components/nativeFilters/FilterBar/index.tsx 50.53% <ø> (ø)
superset/row_level_security/schemas.py 100.00% <ø> (ø)
...d/components/DashboardBuilder/DashboardBuilder.tsx 73.26% <50.00%> (-0.74%) ⬇️
superset/row_level_security/commands/update.py 91.66% <50.00%> (ø)
superset/row_level_security/commands/create.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

"@superset-ui/core": "^0.18.8",
"brace": "^0.11.1",
"cy-verify-downloads": "^0.1.6",
"cypress": "^10.11.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move this to devDependencies?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Fixed

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just left a question about the dependencies vs devdependencies section.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're entering the modern age! Hooray!

@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 26, 2023
@kgabryje
Copy link
Member Author

We're entering the modern age! Hooray!

We still have 2 major versions to catch up on ;) But we're getting there!

@kgabryje kgabryje merged commit 40ae074 into apache:master Apr 26, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants