-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade Cypress to 10.11.0 #23813
Conversation
0b67756
to
da0c1f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #23813 +/- ##
==========================================
+ Coverage 68.00% 68.02% +0.02%
==========================================
Files 1936 1936
Lines 74929 74930 +1
Branches 8141 8141
==========================================
+ Hits 50955 50974 +19
+ Misses 21886 21870 -16
+ Partials 2088 2086 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
"@superset-ui/core": "^0.18.8", | ||
"brace": "^0.11.1", | ||
"cy-verify-downloads": "^0.1.6", | ||
"cypress": "^10.11.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we move this to devDependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just left a question about the dependencies vs devdependencies section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're entering the modern age! Hooray!
We still have 2 major versions to catch up on ;) But we're getting there! |
SUMMARY
Cypress 10.2.0 is the earliest Cypress version that natively supports Apple Silicon. Almost all changes in this PR were done automatically by Cypress's migration tool and the tests are still working just like in our old v7.0.0 without changes.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION