Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerts): flaky test error #23860

Merged

Conversation

justinpark
Copy link
Member

@justinpark justinpark commented Apr 28, 2023

SUMMARY

This commit fixes the following flaky test error.

✕ renders the appropriate dropdown in Message Content section (1160 ms)

  ● renders the appropriate dropdown in Message Content section

    expect(element).toBeChecked()

    Received element is not checked:
      <input class="ant-radio-input" type="radio" value="chart" />

      63 |   userEvent.click(chartRadio);
      64 |
    > 65 |   expect(await screen.findByRole('radio', { name: /chart/i })).toBeChecked();

This commit also cleaned up warnings related to the react-ace editor and onHide prop by using jest.mock.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

Screenshot 2023-04-27 at 9 35 27 PM

Before:

Screenshot 2023-04-27 at 9 33 39 PM

TESTING INSTRUCTIONS

npm run test

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justinpark justinpark force-pushed the fix--flasky-test-on-alert-report-modal branch from 85521e3 to 94fcef3 Compare April 28, 2023 05:13
@pull-request-size pull-request-size bot added size/S and removed size/M labels Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #23860 (1a212cd) into master (053dca1) will not change coverage.
The diff coverage is n/a.

❗ Current head 1a212cd differs from pull request most recent head 94fcef3. Consider uploading reports for the commit 94fcef3 to get more accurate results

@@           Coverage Diff           @@
##           master   #23860   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files        1938     1938           
  Lines       74958    74958           
  Branches     8141     8141           
=======================================
  Hits        51055    51055           
  Misses      21824    21824           
  Partials     2079     2079           
Flag Coverage Δ
javascript 54.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinpark justinpark merged commit 594d3e0 into apache:master Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants