Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove default secret key from helm #23916

Merged
merged 4 commits into from
Nov 29, 2023
Merged

fix: remove default secret key from helm #23916

merged 4 commits into from
Nov 29, 2023

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented May 3, 2023 •
edited
Loading

SUMMARY

Removes yet another default SECRET_KEY from Superset. Also Superset currently uses SUPERSET_SECRET_KEY instead of SECRET_KEY so removing this env key reference here, makes both settings converge.

https://github.com/apache/superset/blob/master/superset/config.py#L184

This is an helm breaking change so it's labelled as 0.11.0

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

rusackas
rusackas approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not helm expert, but these look like very sensible changes to my eyes!

@dpgaspar dpgaspar marked this pull request as ready for review November 29, 2023 11:40
craig-rueda
craig-rueda approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@craig-rueda craig-rueda merged commit 6a5a765 into apache:master Nov 29, 2023
26 checks passed
@craig-rueda craig-rueda deleted the fix/helm-secret-key branch November 29, 2023 15:48
villebro
villebro reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup

@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Nov 30, 2023
michael-s-molina pushed a commit that referenced this pull request Dec 4, 2023
@dpgaspar @michael-s-molina
fix: remove default secret key from helm (#23916)
a5c842c 
(cherry picked from commit 6a5a765)
michael-s-molina pushed a commit that referenced this pull request Dec 4, 2023
@dpgaspar @michael-s-molina
fix: remove default secret key from helm (#23916)
9331969 
(cherry picked from commit 6a5a765)
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@dpgaspar @josedev-union
fix: remove default secret key from helm (apache#23916)
557f93b 
(cherry picked from commit 6a5a765)
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 13, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@dpgaspar @sfirke
fix: remove default secret key from helm (apache#23916)
9ee1e6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro left review comments

@craig-rueda craig-rueda craig-rueda approved these changes

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dpgaspar @rusackas @craig-rueda @villebro @mistercrunch @michael-s-molina