chore(ssh): Allow users to set TUNNEL_TIMEOUT from config #24202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyring
reviewed
May 24, 2023
superset/config.py
Outdated
| @@ -515,6 +515,7 @@ class D3Format(TypedDict, total=False): | |||
| # ---------------------------------------------------------------------- | |||
| SSH_TUNNEL_MANAGER_CLASS = "superset.extensions.ssh.SSHManager" | |||
| SSH_TUNNEL_LOCAL_BIND_ADDRESS = "127.0.0.1" | |||
| SSH_TUNNEL_TIMEOUT = 1.0 | |||
There was a problem hiding this comment.
maybe SSH_TUNNEL_TIMEOUT_SECS?
zephyring
reviewed
May 24, 2023
superset/extensions/ssh.py
Outdated
| @@ -34,6 +34,7 @@ class SSHManager: | |||
| def __init__(self, app: Flask) -> None: | |||
| super().__init__() | |||
| self.local_bind_address = app.config["SSH_TUNNEL_LOCAL_BIND_ADDRESS"] | |||
| TUNNEL_TIMEOUT = app.config["SSH_TUNNEL_TIMEOUT"] | |||
There was a problem hiding this comment.
does this set the TUNNEL_TIMEOUT constant back to sshtunel? or we still need to invoke sshtunel. TUNNEL_TIMEOUT = "value"
can we add a test for this?
Codecov Report
@@ Coverage Diff @@
## master #24202 +/- ##
===========================================
- Coverage 68.30% 57.23% -11.08%
===========================================
Files 1957 1957
Lines 75588 75590 +2
Branches 8223 8223
===========================================
- Hits 51633 43264 -8369
- Misses 21848 30219 +8371
Partials 2107 2107
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 305 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hughhhh
force-pushed
the
ssh-timeout-setting
branch
from
a015cd8
to
af94f53
Compare
zephyring
approved these changes
May 24, 2023
sadpandajoe
added a commit
to preset-io/superset
that referenced
this pull request
Jun 7, 2023
…ache#24202)" This reverts commit 8b0c68c.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Creating a new config variable
SSH_TUNNEL_TIMEOUTthis setting will allowsshtunnelto hold request for this time limit with the VPC.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION