Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sqllab results not rendering after runs (intermittently) #24502

Closed
wants to merge 2 commits into from

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jun 23, 2023

SUMMARY

With this commit sqllab intermittently don't return results back in the bottom pane. Looking at the code i saw this condition for setting the last query updated time and after removing the issue i solved. Still trying to understand the inner workings on why this intially put there, but using this PR as chance to investigate and improve this part of the code base

Screen.Recording.2023-06-23.at.11.07.01.AM.mov

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh
Copy link
Member Author

hughhhh commented Jun 23, 2023

fixes #24487

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #24502 (166d6d3) into master (e6f7c73) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 166d6d3 differs from pull request most recent head 06a5922. Consider uploading reports for the commit 06a5922 to get more accurate results

@@           Coverage Diff           @@
##           master   #24502   +/-   ##
=======================================
  Coverage   69.06%   69.06%           
=======================================
  Files        1901     1901           
  Lines       74019    74018    -1     
  Branches     8116     8116           
=======================================
  Hits        51121    51121           
+ Misses      20787    20786    -1     
  Partials     2111     2111           
Flag Coverage Δ
javascript 55.71% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/reducers/sqlLab.js 43.52% <0.00%> (+0.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant