build(docker): simplification of assembly to facilitate further support #24504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alekseyolg
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
mistercrunch,
craig-rueda,
john-bodley and
kgabryje
as code owners
| @@ -50,7 +50,7 @@ jobs: | |||
| mkdir -p ./build | |||
| echo ${{ github.sha }} > ./build/SHA | |||
| echo ${{ github.event.pull_request.number }} > ./build/PR-NUM | |||
| docker build --target ci -t ${{ github.sha }} -t "pr-${{ github.event.pull_request.number }}" . | |||
| DOCKER_BUILDKIT=1 docker build --target ci -t ${{ github.sha }} -t "pr-${{ github.event.pull_request.number }}" . | |||
There was a problem hiding this comment.
The runner already uses docker-buildx by default. Have a look here. So I don't think it is necessary setting this variable DOCKER_BUILDKIT=1 explicitly. Please correct me if I am wrong.
There was a problem hiding this comment.
@sebastianliebscher Hello!
Originally my code didn't include this, but without it, an error pops up that this variable is not set and a build error occurs.
Apparently this feature is not used by default.
craig-rueda
approved these changes
Jun 24, 2023
|
@craig-rueda @alekseyolg |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the build of the image, a lot of unnecessary duplicate commands are passed, which are redundant. This PR allows you to correct this oversight and allows you to facilitate the process of further support by developers.
Added parameter
DOCKER_BUILDKIT=1to add new features to build the image.Also in the docker-bootstrap.sh script, the if function has been replaced with a case - it looks much better and is easier to maintain. "Unknown Operation!!!" was added to make it clear to users in case of image customization what their mistake is.
TESTING INSTRUCTIONS
Manually build from the Dockerfile,
DOCKER_BUILDKIT=1 docker build -t supersetAnd the build should finish without error.
Successfully tagged superset:latest