Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(helm): reference the correct chart #24570

Merged
merged 1 commit into from
Jul 6, 2023
Merged

docs(helm): reference the correct chart #24570

merged 1 commit into from
Jul 6, 2023

Conversation

muniter
Copy link
Contributor

@muniter muniter commented Jul 1, 2023

SUMMARY

It was pointing to an old unmaintained chart, althought is using the bitnami one.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

helm-docs generates the readme file with the changes.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

github-actions[bot]
github-actions bot reviewed Jul 1, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

michael-s-molina
michael-s-molina approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @muniter!

craig-rueda
craig-rueda reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a version bump to pass CI

@muniter
Copy link
Contributor Author

muniter commented Jul 5, 2023

This will need a version bump to pass CI

Thanks for the review. Done.

@craig-rueda craig-rueda merged commit 52ab974 into apache:master Jul 6, 2023
@muniter muniter deleted the fix-helm-ref branch July 6, 2023 16:41
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@muniter
docs(helm): reference the correct chart (apache#24570)
119e89d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@craig-rueda craig-rueda craig-rueda approved these changes

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

@villebro villebro Awaiting requested review from villebro villebro is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muniter @craig-rueda @michael-s-molina @mistercrunch