Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obsolete fetchExploreJson function #24669

Merged

Conversation

john-bodley
Copy link
Member

SUMMARY

Whilst spelunking in the code I realized that the fetchExploreJson method wasn't used outside of testing and thus warranted being deleted.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley force-pushed the john-bodley--remove-fetchExploreJson branch from fcdabf7 to 1610cec Compare July 11, 2023 22:12
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #24669 (0a739ce) into master (1473d97) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0a739ce differs from pull request most recent head 1610cec. Consider uploading reports for the commit 1610cec to get more accurate results

@@            Coverage Diff             @@
##           master   #24669      +/-   ##
==========================================
- Coverage   69.03%   69.02%   -0.01%     
==========================================
  Files        1908     1907       -1     
  Lines       74197    74190       -7     
  Branches     8186     8181       -5     
==========================================
- Hits        51219    51212       -7     
  Misses      20857    20857              
  Partials     2121     2121              
Flag Coverage Δ
javascript 55.71% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley john-bodley changed the title John bodley remove fetch explore json chore: remove fetch explore json Jul 12, 2023
@john-bodley john-bodley marked this pull request as ready for review July 12, 2023 16:55
@john-bodley john-bodley merged commit a3db584 into apache:master Jul 13, 2023
@john-bodley john-bodley changed the title chore: remove fetch explore json chore: remove fetchExploreJson Aug 1, 2023
@john-bodley john-bodley changed the title chore: remove fetchExploreJson chore: remove obsolete fetchExploreJson function Aug 1, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants