Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump PyYAML bounds #24731

Merged
merged 1 commit into from
Jul 18, 2023
Merged

chore: Bump PyYAML bounds #24731

merged 1 commit into from
Jul 18, 2023

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jul 18, 2023 •
edited
Loading

SUMMARY

Bumping PyYAML bounds to address yaml/pyyaml#724 which is currently breaking CI.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Recompiled the dependencies via,

python3.9 -m pip install -r requirements/integration.txt
pip-compile-multi --no-upgrade

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 18, 2023 •
edited
Loading

Codecov Report

Merging #24731 (b95c30e) into master (1b5a679) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head b95c30e differs from pull request most recent head eafa9db. Consider uploading reports for the commit eafa9db to get more accurate results

@@            Coverage Diff             @@
##           master   #24731      +/-   ##
==========================================
+ Coverage   68.86%   68.89%   +0.02%     
==========================================
  Files        1901     1901              
  Lines       73927    73927              
  Branches     8183     8183              
==========================================
+ Hits        50913    50932      +19     
+ Misses      20893    20874      -19     
  Partials     2121     2121
Flag Coverage Δ
hive 54.15% <ø> (ø)
mysql 79.21% <ø> (ø)
postgres 79.29% <ø> (ø)
presto 54.05% <ø> (ø)
python 83.31% <ø> (+0.05%) ⬆️
sqlite 77.88% <ø> (?)
unit 54.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley john-bodley marked this pull request as ready for review July 18, 2023 19:37
michael-s-molina
michael-s-molina approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

john-bodley
john-bodley commented Jul 18, 2023
View reviewed changes
requirements/integration.txt
# via pre-commit
tomli==2.0.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this wasn't present previously. Possibly a problematic failed prior run of pip-compile-multi and/or pinning requirements outside of said tool.

requirements/testing.txt
@@ -16,6 +16,8 @@ cmdstanpy==1.1.0
# via prophet
contourpy==1.0.7
# via matplotlib
convertdate==2.4.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment.

requirements/testing.txt
@@ -121,6 +123,8 @@ pyfakefs==5.2.2
# via -r requirements/testing.in
pyhive[presto]==0.6.5
# via apache-superset
pymeeus==0.5.12
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment.

setup.py
@@ -111,7 +111,7 @@ def get_git_sha() -> str:
"python-dotenv",
"python-geohash",
"pyarrow>=12.0.0, <13",
"pyyaml>=5.4",
"pyyaml>=6.0.0, <7.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A side note. It likely would be good (in a follow up PR) to:

  1. Add bounds to all packages.
  2. Ensure consistent version specification, i.e., adhere to the <major>.<minor>.<patch> version construct (if applicable).

@john-bodley john-bodley added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 18, 2023
@john-bodley john-bodley merged commit aa01b51 into apache:master Jul 18, 2023
@john-bodley john-bodley changed the title chore: Bump pyyaml bounds chore: Bump PyYAML bounds Jul 20, 2023
@michael-s-molina michael-s-molina mentioned this pull request Jul 20, 2023
Merged
9 tasks
michael-s-molina pushed a commit that referenced this pull request Jul 26, 2023
@john-bodley @michael-s-molina
chore: Bump pyyaml bounds (#24731)
65822ca
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@john-bodley
chore: Bump pyyaml bounds (apache#24731)
42782b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-bodley @michael-s-molina @mistercrunch