Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Alembic migration head #24832

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jul 28, 2023

SUMMARY

This PR fixes an issue where previously there were two Alembic heads.

BEFORE

$ FLASK_DEBUG=true superset db heads
e0f6f91c2055 (head)
ee179a490af9 (head)

i.e., the history of the two heads were:

e0f6f91c2055 <- bf646a0c1501 <- a23c6f8b1280 <- 863adcf72773
ee179a490af9 <- a23c6f8b1280

AFTER

$ FLASK_DEBUG=true superset db heads
ee179a490af9 (head)

whereas after the change, i.e, making the down revision of ee179a490af9 to be e0f6f91c2055 the history is:

ee179a490af9 <- e0f6f91c2055 <- bf646a0c1501 <- a23c6f8b1280 <- 863adcf72773

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley marked this pull request as ready for review July 28, 2023 05:52
@john-bodley john-bodley requested a review from a team as a code owner July 28, 2023 05:52
@john-bodley john-bodley added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch and removed v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch labels Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #24832 (f7bfd63) into master (7cd317f) will increase coverage by 13.56%.
The diff coverage is n/a.

❗ Current head f7bfd63 differs from pull request most recent head a9f2647. Consider uploading reports for the commit a9f2647 to get more accurate results

@@             Coverage Diff             @@
##           master   #24832       +/-   ##
===========================================
+ Coverage   55.43%   68.99%   +13.56%     
===========================================
  Files        1903     1903               
  Lines       74077    74077               
  Branches     8194     8194               
===========================================
+ Hits        41064    51112    +10048     
+ Misses      30892    20844    -10048     
  Partials     2121     2121               
Flag Coverage Δ
hive 54.13% <ø> (?)
mysql 79.21% <ø> (?)
postgres 79.31% <ø> (?)
presto 54.03% <ø> (?)
python 83.36% <ø> (+28.37%) ⬆️
sqlite 77.88% <ø> (?)
unit 54.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 321 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dpgaspar dpgaspar merged commit a50c43e into apache:master Jul 28, 2023
54 checks passed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants