-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update Tags CRUD API #24839
feat: Update Tags CRUD API #24839
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24839 +/- ##
=======================================
Coverage 69.00% 69.00%
=======================================
Files 1906 1903 -3
Lines 74133 74129 -4
Branches 8208 8193 -15
=======================================
+ Hits 51153 51154 +1
+ Misses 20857 20854 -3
+ Partials 2123 2121 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 131 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
805abde
to
d94815f
Compare
d94815f
to
68d8ebf
Compare
bf3f559
to
11ec0b6
Compare
11ec0b6
to
6a61d89
Compare
…into tags-modal-api
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.. thanks @hughhhh!
So I've been looking for this "New Tag" button for a while now, but it doesn't seem to exist in the Next to this, even though this PR was merged into How can I go about enabling this? |
Hi @jordibeen, you can test out the feature by turning on the |
Yes, the issue I mentioned above is with the Enabling this does give us the option to create and apply tags on a Chart (by editing the Chart Properties), but it doesn't add the "New Tag" button on the Tag ListView page. We're looking for some kind of "Tag management" like in the video above, but our [superset-domain]/superset/tags page doesn't have all the functionalities that the video in this PR shows, such as the "New Tag" button in the top right. (We're on 3.0.0) Even though this PR was merged into master on August 25, it doesn't seem to exist in the source code of the upcoming 3.0.1rc1 release candidate. I guess my question is: which Superset version will contain this great new |
SUMMARY
Updated API to allow users to create a
Tag
w/ description. Also user's can bulk tag resources from the new CRUD modal in theTags
ListView page.Note: I did fix the onHide functionality that's not show in the video when the user completes
Screen.Recording.2023-07-31.at.12.02.39.PM.mov
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION