Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Tags CRUD API #24839

Merged
merged 30 commits into from
Aug 25, 2023
Merged

feat: Update Tags CRUD API #24839

merged 30 commits into from
Aug 25, 2023

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jul 30, 2023

SUMMARY

Updated API to allow users to create a Tag w/ description. Also user's can bulk tag resources from the new CRUD modal in the Tags ListView page.

Note: I did fix the onHide functionality that's not show in the video when the user completes

Screen.Recording.2023-07-31.at.12.02.39.PM.mov

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #24839 (5a6c286) into master (ec9e9a4) will increase coverage by 0.00%.
The diff coverage is 79.66%.

❗ Current head 5a6c286 differs from pull request most recent head 04020c8. Consider uploading reports for the commit 04020c8 to get more accurate results

@@           Coverage Diff           @@
##           master   #24839   +/-   ##
=======================================
  Coverage   69.00%   69.00%           
=======================================
  Files        1906     1903    -3     
  Lines       74133    74129    -4     
  Branches     8208     8193   -15     
=======================================
+ Hits        51153    51154    +1     
+ Misses      20857    20854    -3     
+ Partials     2123     2121    -2     
Flag Coverage Δ
hive 54.09% <30.50%> (-0.09%) ⬇️
mysql 79.20% <76.27%> (-0.01%) ⬇️
postgres 79.30% <76.27%> (-0.01%) ⬇️
presto 53.99% <30.50%> (-0.09%) ⬇️
python 83.36% <79.66%> (-0.01%) ⬇️
sqlite 77.88% <76.27%> (-0.01%) ⬇️
unit 55.05% <71.18%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
superset-frontend/src/pages/Tags/index.tsx 0.00% <ø> (ø)
superset/tags/api.py 73.83% <65.00%> (-1.33%) ⬇️
superset/tags/commands/create.py 80.70% <84.00%> (+2.57%) ⬆️
superset/daos/tag.py 95.00% <90.90%> (-0.42%) ⬇️
superset/tags/schemas.py 100.00% <100.00%> (ø)

... and 131 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh force-pushed the tags-modal-api branch 5 times, most recently from 805abde to d94815f Compare August 10, 2023 16:27
hughhhh and others added 2 commits August 24, 2023 18:22
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
@hughhhh hughhhh requested a review from eschutho August 24, 2023 16:32
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.. thanks @hughhhh!

@hughhhh hughhhh merged commit 69fb309 into apache:master Aug 25, 2023
29 checks passed
@hughhhh hughhhh deleted the tags-modal-api branch August 25, 2023 19:16
@jordibeen
Copy link

So I've been looking for this "New Tag" button for a while now, but it doesn't seem to exist in the apache/superset:3.0.0 docker image.

Next to this, even though this PR was merged into master on August 25, it doesn't seem to exist in the source code of the upcoming 3.0.1rc1 release candidate either.

How can I go about enabling this?

@eschutho
Copy link
Member

Hi @jordibeen, you can test out the feature by turning on the TAGGING_SYSTEM feature flag in your config. It's still in a development/testing stage, so you may find it a little buggy until it's ready for GA, which will likely be around the 3.1 release.

@jordibeen
Copy link

Yes, the issue I mentioned above is with the TAGGING_SYSTEM feature flag already enabled.

Enabling this does give us the option to create and apply tags on a Chart (by editing the Chart Properties), but it doesn't add the "New Tag" button on the Tag ListView page.

We're looking for some kind of "Tag management" like in the video above, but our [superset-domain]/superset/tags page doesn't have all the functionalities that the video in this PR shows, such as the "New Tag" button in the top right. (We're on 3.0.0)

Even though this PR was merged into master on August 25, it doesn't seem to exist in the source code of the upcoming 3.0.1rc1 release candidate.

I guess my question is: which Superset version will contain this great new Tag ListView page?

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants