Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignores hot update files when generating the manifest #24871

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes the following error when running Superset with hot update enabled:

Screenshot 2023-08-02 at 15 17 11


This happens because the manifest file was being generated with [hash].hot-update.js files. This PR adds a filter to the Webpack config to ignore these files.

TESTING INSTRUCTIONS

Make sure the console error does not appear when hot updating a file with npm run dev-server

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #24871 (0618a9a) into master (1a9c559) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 50.87%.

❗ Current head 0618a9a differs from pull request most recent head 0a01d55. Consider uploading reports for the commit 0a01d55 to get more accurate results

@@            Coverage Diff             @@
##           master   #24871      +/-   ##
==========================================
- Coverage   69.00%   69.00%   -0.01%     
==========================================
  Files        1904     1906       +2     
  Lines       74107    74135      +28     
  Branches     8194     8207      +13     
==========================================
+ Hits        51140    51154      +14     
- Misses      20848    20860      +12     
- Partials     2119     2121       +2     
Flag Coverage Δ
javascript 55.83% <50.87%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...s/legacy-plugin-chart-heatmap/src/controlPanel.tsx 57.14% <ø> (ø)
.../legacy-plugin-chart-heatmap/src/transformProps.js 0.00% <ø> (ø)
.../legacy-plugin-chart-world-map/src/controlPanel.ts 25.00% <ø> (ø)
...egacy-plugin-chart-world-map/src/transformProps.js 0.00% <ø> (ø)
...harts/src/BigNumber/BigNumberTotal/controlPanel.ts 30.00% <ø> (ø)
...rts/src/BigNumber/BigNumberTotal/transformProps.ts 0.00% <ø> (ø)
.../BigNumber/BigNumberWithTrendline/controlPanel.tsx 16.66% <ø> (ø)
...BigNumber/BigNumberWithTrendline/transformProps.ts 48.57% <ø> (ø)
...s/plugin-chart-echarts/src/Funnel/controlPanel.tsx 66.66% <ø> (ø)
... and 40 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit aee2695 into apache:master Aug 3, 2023
27 checks passed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants