Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(native-filters): Remove outdated statement #24873

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

john-bodley
Copy link
Member

SUMMARY

This PR removes a statement which is no longer accurate. The cleanup phase of the native dashboard filter migration only deletes the filter boxes associated with the identified dashboards.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #24873 (9573b55) into master (bf1b1a4) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24873   +/-   ##
=======================================
  Coverage   69.00%   69.00%           
=======================================
  Files        1906     1906           
  Lines       74139    74139           
  Branches     8209     8209           
=======================================
+ Hits        51156    51159    +3     
+ Misses      20862    20859    -3     
  Partials     2121     2121           
Flag Coverage Δ
hive 54.13% <ø> (ø)
javascript 55.84% <ø> (+<0.01%) ⬆️
mysql 79.22% <ø> (ø)
postgres 79.32% <ø> (ø)
presto 54.03% <ø> (ø)
python 83.37% <ø> (ø)
sqlite 77.89% <ø> (ø)
unit 55.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unfamiliar with this command group so if there's any doubt there it should get another perspective - but it seems clear-cut.

@john-bodley john-bodley merged commit 7edcbc9 into master Aug 3, 2023
53 checks passed
@john-bodley john-bodley deleted the john-bodley--docs-native-filters branch August 3, 2023 16:51
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants