-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update UPDATING.md regarding potential breaking change to ab_user.email
column
#25115
Merged
michael-s-molina
merged 2 commits into
apache:master
from
john-bodley:john-bodley--docs-bump-supported-mysql-versions
Aug 30, 2023
Merged
docs: Update UPDATING.md regarding potential breaking change to ab_user.email
column
#25115
michael-s-molina
merged 2 commits into
apache:master
from
john-bodley:john-bodley--docs-bump-supported-mysql-versions
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
added
the
v3.0
Label added by the release manager to track PRs to be included in the 3.0 branch
label
Aug 29, 2023
john-bodley
commented
Aug 29, 2023
@@ -106,7 +106,7 @@ Superset supports the following database engines/versions: | |||
| Database Engine | Supported Versions | | |||
| --------------------------------------------------------- | ---------------------------------- | | |||
| [PostgreSQL](https://www.postgresql.org/) | 10.X, 11.X, 12.X, 13.X, 14.X, 15.X | | |||
| [MySQL](https://www.mysql.com/) | 5.X | | |||
| [MySQL](https://www.mysql.com/) | 5.7, 8.X | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed prudent to list the supported versions of MySQL, i.e., those which are the currently supported.
…ser.email` column
john-bodley
force-pushed
the
john-bodley--docs-bump-supported-mysql-versions
branch
from
August 29, 2023 20:54
a3a5a6e
to
0ed7904
Compare
michael-s-molina
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the update @john-bodley!
michael-s-molina
added a commit
that referenced
this pull request
Aug 30, 2023
…ser.email` column (#25115) Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
darwinsubramaniam
pushed a commit
to darwinsubramaniam/superset
that referenced
this pull request
Sep 7, 2023
…ser.email` column (apache#25115) Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…ser.email` column (apache#25115) Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
mistercrunch
added
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 3.1.0
labels
Mar 8, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
…ser.email` column (apache#25115) Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
#25053 extended the
ab_user.email
column (which has a uniqueness key constraint associated with it) from 64 to 320 characters. This change could be problematic for some MySQL databases and thus this PR updates theUPDATING.md
to include a line item about how the database needs to be reconfigured if this is indeed problematic.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION