Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sqllab): Typescript for SqlEditor component #25228

Merged
merged 8 commits into from
Oct 5, 2023
Merged

chore(sqllab): Typescript for SqlEditor component #25228

merged 8 commits into from
Oct 5, 2023

Conversation

justinpark
Copy link
Member

SUMMARY

This commit migrates SqlEditor jsx to tsx along with all associated type updates.

TESTING INSTRUCTIONS

npm run type

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justinpark justinpark mentioned this pull request Sep 11, 2023
Closed
9 tasks
michael-s-molina
michael-s-molina reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @justinpark. I left some first-pass comments.

superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx Outdated Show resolved Hide resolved
superset-frontend/src/SqlLab/components/SaveQuery/index.tsx Outdated Show resolved Hide resolved
superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx Outdated Show resolved Hide resolved
@justinpark justinpark force-pushed the chore--sqllab-editor-to-typescript branch 2 times, most recently from 7f1d5e6 to 39fd80e Compare September 25, 2023 20:53
@justinpark
Copy link
Member Author

@michael-s-molina could you review the update again?

michael-s-molina
michael-s-molina approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Thanks for addressing all comments @justinpark!

@justinpark justinpark force-pushed the chore--sqllab-editor-to-typescript branch from eae9244 to 30a9610 Compare October 5, 2023 15:10
@justinpark justinpark merged commit 34f9970 into apache:master Oct 5, 2023
26 checks passed
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@justinpark
chore(sqllab): Typescript for SqlEditor component (apache#25228)
9578b39
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@justinpark
chore(sqllab): Typescript for SqlEditor component (apache#25228)
79d50bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@eschutho eschutho Awaiting requested review from eschutho

@kgabryje kgabryje Awaiting requested review from kgabryje

@Antonio-RiveroMartnez Antonio-RiveroMartnez Awaiting requested review from Antonio-RiveroMartnez

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinpark @michael-s-molina @mistercrunch