Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cryptography version bump #25276

Merged
merged 4 commits into from
Sep 26, 2023
Merged

chore: cryptography version bump #25276

merged 4 commits into from
Sep 26, 2023

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Sep 12, 2023 •
edited by michael-s-molina
Loading

SUMMARY

  • Upgrade cryptography to version 41.0.2

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang requested a review from a team September 12, 2023 21:33
betodealmeida
betodealmeida reviewed Sep 12, 2023
View reviewed changes
setup.py Outdated
@@ -81,7 +81,7 @@ def get_git_sha() -> str:
"colorama",
"croniter>=0.3.28",
"cron-descriptor",
"cryptography>=41.0.0, <41.0.2",
"cryptography>=41.0.0, <=41.0.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're bumping due to a CVE let's increase the lower bound here as well.

michael-s-molina
michael-s-molina reviewed Sep 13, 2023
View reviewed changes
setup.py Outdated Show resolved Hide resolved
Lily Kuang and others added 2 commits September 21, 2023 13:28
@michael-s-molina
Update setup.py
1883368 
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Merge remote-tracking branch 'origin/master' into lily/vanta-security…
5b69c9a 
…-update
@lilykuang lilykuang merged commit 40ba3c2 into apache:master Sep 26, 2023
26 checks passed
@lilykuang lilykuang deleted the lily/vanta-security-update branch September 26, 2023 23:01
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@michael-s-molina
chore: cryptography version bump (apache#25276)
652e670 
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@michael-s-molina
chore: cryptography version bump (apache#25276)
d6614dc 
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina left review comments

@dpgaspar dpgaspar dpgaspar left review comments

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lilykuang @betodealmeida @dpgaspar @michael-s-molina @mistercrunch