-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add snowflake-sqlalchemy in ./docker/requirements-local.txt #25312
Conversation
If using Docker Compose to run Superset, the snowflake-sqlalchemy library should be added to the./docker/requirements-local.txt file for Superset to recognise the Snowflake database connector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting a PR! I think this is a small improvement, it doesn't hurt, but it is symptomatic of a bigger problem. There is a whole section that describes this process: https://superset.apache.org/docs/databases/docker-add-drivers/ and I'd rather not duplicate that content. It shouldn't need to be in every single database page, ideally. Most DB pages (for instance MySQL, Snowflake) don't repeat this info. I like how it's documented on the BigQuery page, where it links back to the main docker driver docs. Could you instead link back to the main add driver page, copying the BigQuery example? I would merge that. Though to me it says something bigger should also be improved if we have to link back to that page from every single DB subpage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include a link back to this page: https://superset.apache.org/docs/databases/docker-add-drivers/
See https://superset.apache.org/docs/databases/bigquery for example.
@sfirke, Thank you for responding. I made the necessary changes as suggested by you. Currently, looking at the Snowflake page and connecting is not very intuitive. Linking back to this doc makes it easier for someone new to Superset and Snowflake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for updating!
If using Docker Compose to run Superset, the snowflake-sqlalchemy library should be added to the./docker/requirements-local.txt file for Superset to recognise the Snowflake database connector.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION