Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docker-compose #25332

Merged
merged 4 commits into from
Sep 26, 2023
Merged

docs: update docker-compose #25332

merged 4 commits into from
Sep 26, 2023

Conversation

nytai
Copy link
Member

@nytai nytai commented Sep 18, 2023

SUMMARY

Update docker-compose docs to emphasize the issues with the docker-compose up and the node assets not building for 95% of users. Also updating the suggested tag to the latest release.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@nytai nytai changed the title Update docker-compose docs docs: update docker-compose Sep 18, 2023
@nytai nytai requested a review from hughhhh September 18, 2023 21:39
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #25332 (7a38445) into master (090ae64) will increase coverage by 10.34%.
Report is 14 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #25332       +/-   ##
===========================================
+ Coverage   58.75%   69.09%   +10.34%     
===========================================
  Files        1905     1905               
  Lines       74760    74760               
  Branches     8270     8270               
===========================================
+ Hits        43923    51654     +7731     
+ Misses      28698    20967     -7731     
  Partials     2139     2139               
Flag Coverage Δ
hive 53.75% <ø> (ø)
javascript 56.14% <ø> (ø)
mysql 78.45% <ø> (?)
postgres 78.55% <ø> (?)
presto 53.70% <ø> (ø)
python 82.98% <ø> (+21.43%) ⬆️
sqlite 77.19% <ø> (?)
unit 55.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 293 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…e.mdx


bump text version to 3.0.0

Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
nytai and others added 2 commits September 25, 2023 14:50
…e.mdx

Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
…e.mdx

Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@nytai nytai requested a review from sfirke September 25, 2023 21:52
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfirke sfirke merged commit 52eba11 into master Sep 26, 2023
52 checks passed
@sfirke sfirke deleted the nytai-patch-2 branch September 26, 2023 14:16
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Also notes that one needn't build a new image.

Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Also notes that one needn't build a new image.

Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants