-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update docker-compose #25332
docs: update docker-compose #25332
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25332 +/- ##
===========================================
+ Coverage 58.75% 69.09% +10.34%
===========================================
Files 1905 1905
Lines 74760 74760
Branches 8270 8270
===========================================
+ Hits 43923 51654 +7731
+ Misses 28698 20967 -7731
Partials 2139 2139
Flags with carried forward coverage won't be shown. Click here to find out more. see 293 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
e55cb73
to
d24f23e
Compare
docs/docs/installation/installing-superset-using-docker-compose.mdx
Outdated
Show resolved
Hide resolved
…e.mdx bump text version to 3.0.0 Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
docs/docs/installation/installing-superset-using-docker-compose.mdx
Outdated
Show resolved
Hide resolved
docs/docs/installation/installing-superset-using-docker-compose.mdx
Outdated
Show resolved
Hide resolved
…e.mdx Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
…e.mdx Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also notes that one needn't build a new image. Co-authored-by: Sam Firke <sfirke@users.noreply.github.com> Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
Also notes that one needn't build a new image. Co-authored-by: Sam Firke <sfirke@users.noreply.github.com> Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
SUMMARY
Update docker-compose docs to emphasize the issues with the
docker-compose up
and the node assets not building for 95% of users. Also updating the suggested tag to the latest release.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION