Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds the ECharts Heatmap chart #25353

Merged
merged 10 commits into from
Mar 28, 2024

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Sep 20, 2023

SUMMARY

This PR introduces the ECharts version of the Heatmap chart. In comparison with the legacy version, the new plugin has more accurate percentage calculations, server side sorting to respect row limits, and an improved legend control that allows selecting a subset of values.

Fixes #26092, #25981

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2024-03-27.at.09.02.16.mov

TESTING INSTRUCTIONS

Check all features.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 88 lines in your changes are missing coverage. Please review.

Project coverage is 69.82%. Comparing base (d69a187) to head (e5d9183).

Files Patch % Lines
...plugin-chart-echarts/src/Heatmap/transformProps.ts 1.40% 70 Missing ⚠️
...ins/plugin-chart-echarts/src/Heatmap/buildQuery.ts 0.00% 9 Missing ⚠️
superset/utils/pandas_postprocessing/rank.py 37.50% 5 Missing ⚠️
...ugins/plugin-chart-echarts/src/Heatmap/Heatmap.tsx 0.00% 2 Missing ⚠️
.../plugin-chart-echarts/src/Heatmap/controlPanel.tsx 66.66% 1 Missing ⚠️
.../plugins/plugin-chart-echarts/src/Heatmap/index.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25353      +/-   ##
==========================================
+ Coverage   67.47%   69.82%   +2.34%     
==========================================
  Files        1911     1920       +9     
  Lines       75019    75204     +185     
  Branches     8352     8416      +64     
==========================================
+ Hits        50620    52509    +1889     
+ Misses      22349    20631    -1718     
- Partials     2050     2064      +14     
Flag Coverage Δ
hive 48.93% <44.44%> (?)
mysql 77.90% <44.44%> (-0.01%) ⬇️
postgres 78.01% <44.44%> (-0.01%) ⬇️
presto 53.64% <44.44%> (?)
python 83.14% <44.44%> (+4.98%) ⬆️
sqlite 77.45% <44.44%> (-0.01%) ⬇️
unit 56.75% <44.44%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina michael-s-molina marked this pull request as ready for review March 27, 2024 12:17
@michael-s-molina michael-s-molina force-pushed the echarts-heatmap branch 2 times, most recently from 14b3ed7 to d26979d Compare March 27, 2024 17:20
@michael-s-molina michael-s-molina merged commit 546d48a into apache:master Mar 28, 2024
40 checks passed
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
eschutho pushed a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants