-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds the ECharts Heatmap chart #25353
Merged
michael-s-molina
merged 10 commits into
apache:master
from
michael-s-molina:echarts-heatmap
Mar 28, 2024
Merged
feat: Adds the ECharts Heatmap chart #25353
michael-s-molina
merged 10 commits into
apache:master
from
michael-s-molina:echarts-heatmap
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
force-pushed
the
echarts-heatmap
branch
from
September 22, 2023 13:00
b752300
to
3206e7f
Compare
michael-s-molina
force-pushed
the
echarts-heatmap
branch
from
November 2, 2023 13:44
3206e7f
to
6c6438a
Compare
michael-s-molina
force-pushed
the
echarts-heatmap
branch
from
March 18, 2024 16:24
f962c0c
to
d9f0ca9
Compare
michael-s-molina
force-pushed
the
echarts-heatmap
branch
2 times, most recently
from
March 19, 2024 21:58
d2d250d
to
ca01e3e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #25353 +/- ##
==========================================
+ Coverage 67.47% 69.82% +2.34%
==========================================
Files 1911 1920 +9
Lines 75019 75204 +185
Branches 8352 8416 +64
==========================================
+ Hits 50620 52509 +1889
+ Misses 22349 20631 -1718
- Partials 2050 2064 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michael-s-molina
requested review from
justinpark,
kgabryje,
stephenLYZ,
villebro and
a team
March 27, 2024 12:18
michael-s-molina
force-pushed
the
echarts-heatmap
branch
2 times, most recently
from
March 27, 2024 17:20
14b3ed7
to
d26979d
Compare
michael-s-molina
force-pushed
the
echarts-heatmap
branch
from
March 27, 2024 19:26
d26979d
to
3360469
Compare
justinpark
approved these changes
Mar 27, 2024
EandrewJones
pushed a commit
to UMD-ARLIS/superset
that referenced
this pull request
Apr 5, 2024
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
Apr 12, 2024
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
eschutho
pushed a commit
that referenced
this pull request
Jun 5, 2024
(cherry picked from commit 546d48a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR introduces the ECharts version of the Heatmap chart. In comparison with the legacy version, the new plugin has more accurate percentage calculations, server side sorting to respect row limits, and an improved legend control that allows selecting a subset of values.
Fixes #26092, #25981
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2024-03-27.at.09.02.16.mov
TESTING INSTRUCTIONS
Check all features.
ADDITIONAL INFORMATION