Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docker compose instructions #25479

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Conversation

mdeshmu
Copy link
Contributor

@mdeshmu mdeshmu commented Oct 1, 2023

SUMMARY

Address bugherd task 69 & 73

cc: @sfirke @rusackas

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@mdeshmu mdeshmu force-pushed the bugherd-69 branch 2 times, most recently from e1fc972 to 8f3c7ff Compare October 1, 2023 11:47
@mdeshmu mdeshmu changed the title docs: update docker compose instructions for windows docs: update docker compose instructions Oct 1, 2023
@mdeshmu mdeshmu mentioned this pull request Oct 1, 2023
9 tasks
@sfirke sfirke added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Oct 2, 2023
@sfirke
Copy link
Member

sfirke commented Oct 2, 2023

@mdeshmu I see this failed a check 😕

@mdeshmu
Copy link
Contributor Author

mdeshmu commented Oct 2, 2023

@sfirke pre-commit failure is not related to this PR.

tests/unit_tests/db_engine_specs/test_clickhouse.py:66: error: Argument 1 to "NewConnectionError" has incompatible type "str"; expected "HTTPConnection" [arg-type]

@sfirke
Copy link
Member

sfirke commented Oct 2, 2023

Thanks for looking into the failed check! Unfortunately merging is blocked by CI rules until that unrelated thing is fixed. Either of us can close and re-open when we think that part of the build has been fixed, to re-trigger CI checks.

And thanks for sending these multiple PRs, that's a great contribution 🙏

@john-bodley
Copy link
Member

john-bodley commented Oct 2, 2023

@mdeshmu would you mind providing links to the issues you mentioned to aid with context?

@sfirke
Copy link
Member

sfirke commented Oct 2, 2023

@john-bodley before I write the same thing on the four different PRs, are you looking for the link to BugHerd or some other reference?

@mdeshmu
Copy link
Contributor Author

mdeshmu commented Oct 3, 2023

This is ready to merge

@sfirke sfirke merged commit 23996b5 into apache:master Oct 3, 2023
28 checks passed
@mdeshmu mdeshmu deleted the bugherd-69 branch October 13, 2023 15:25
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels merge-if-green If approved and tests are green, please go ahead and merge it for me size/S 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants