Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tags Page ListView size to 10 #25536

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix: Tags Page ListView size to 10 #25536

merged 1 commit into from
Oct 5, 2023

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Oct 5, 2023

SUMMARY

Updating page size to be 10 via @yousoph request in Tags.AllEntitiesPage
Screenshot 2023-10-03 at 8 31 13 PM

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #25536 (9a9edbe) into master (4532079) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25536      +/-   ##
==========================================
+ Coverage   69.10%   69.12%   +0.01%     
==========================================
  Files        1915     1915              
  Lines       75103    75103              
  Branches     8307     8307              
==========================================
+ Hits        51903    51914      +11     
+ Misses      21059    21048      -11     
  Partials     2141     2141              
Flag Coverage Δ
hive 53.63% <ø> (ø)
mysql 78.26% <ø> (?)
postgres 78.36% <ø> (+0.01%) ⬆️
presto 53.58% <ø> (ø)
python 82.78% <ø> (+0.03%) ⬆️
sqlite 77.01% <ø> (ø)
unit 55.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tend/src/features/allEntities/AllEntitiesTable.tsx 0.00% <ø> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh merged commit 0c40bea into master Oct 5, 2023
56 checks passed
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the hughhhh-patch-11 branch March 26, 2024 17:56
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants