Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updated base DAO find_by_id to return generic type #25726

Merged
merged 1 commit into from
Oct 23, 2023
Merged

chore: updated base DAO find_by_id to return generic type #25726

merged 1 commit into from
Oct 23, 2023

Conversation

zephyring
Copy link
Contributor

@zephyring zephyring commented Oct 20, 2023 •
edited
Loading

SUMMARY

  1. updated return type to be T for find_by_id instead of model. This could help reduce mypy warning on type cast.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

craig-rueda
craig-rueda reviewed Oct 23, 2023
View reviewed changes
superset/daos/base.py
@@ -62,7 +62,7 @@ def find_by_id(
model_id: str | int,
session: Session = None,
skip_base_filter: bool = False,
) -> Model | None:
) -> T | None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you force T to extend Model (if it already is that way, nvm)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is

superset/superset/daos/base.py

Line 35 in 26e5a69

T = TypeVar("T", bound=Model)

@craig-rueda craig-rueda merged commit 4aef771 into apache:master Oct 23, 2023
32 checks passed
@craig-rueda craig-rueda deleted the zef/fix_base_dao_generic_type branch October 23, 2023 14:46
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
chore: updated base DAO find_by_id to return generic type (apache#25726)
22abebb
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@sfirke
chore: updated base DAO find_by_id to return generic type (apache#25726)
acaecb3
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
chore: updated base DAO find_by_id to return generic type (apache#25726)
6865695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-rueda craig-rueda craig-rueda approved these changes

@Antonio-RiveroMartnez Antonio-RiveroMartnez Antonio-RiveroMartnez approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zephyring @craig-rueda @Antonio-RiveroMartnez @mistercrunch