Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add example charts for deck.gl #25770

Merged
merged 4 commits into from
Jan 3, 2024
Merged

chore: Add example charts for deck.gl #25770

merged 4 commits into from
Jan 3, 2024

Conversation

willie-hung
Copy link
Contributor

@willie-hung willie-hung commented Oct 26, 2023 •
edited
Loading

SUMMARY

Adding chart examples for Deck.gl:

  • Multiple Layer
  • Arc
  • Grid
  • Hexagon
  • Path
  • Polygon
  • Scatterplot
  • Screen Grid
  • Contour
  • Heatmap
  • Geojson

SCREENSHOT

Screenshot 2023-10-26 at 4 08 13 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Partially solves [Gallery] Some chart type in gallery do not have example #16707
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@willie-hung
Add example charts for deck.gl
81dc0f5 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
github-actions[bot]
github-actions bot reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@willie-hung
change example photo & variable name
2888b0d 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@john-bodley
Copy link
Member

@Willie-The-Lord thanks for adding examples to help improve the UX. I've requested review from some frontend engineers.

@michael-s-molina
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://52.34.70.66:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@michael-s-molina
Copy link
Member

Could you add examples for deck.gl Geojson, deck.gl Heatmap and deck.gl Countour? Then all deck.gl charts will have associated examples.

Screenshot 2023-10-30 at 19 35 36

@willie-hung
Copy link
Contributor Author

Could you add examples for deck.gl Geojson, deck.gl Heatmap and deck.gl Countour? Then all deck.gl charts will have associated examples.

No problem. I'll go ahead and create the examples. Thank you for bringing this to my attention!

@willie-hung
Add contour, geojson, and heatmap example image
94be206 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@willie-hung
Copy link
Contributor Author

Hi @michael-s-molina, I've added deck.gl geojson, deck.gl heatmap and deck.gl contour example images. Also, I notice that it should be Contour instead of Countour here. Should I raise an issue to address this separately? Thanks!

Screenshot 2023-12-11 at 10 37 01 PM

@michael-s-molina
Copy link
Member

Also, I notice that it should be Contour instead of Countour here. Should I raise an issue to address this separately?

If you can fix this in this PR it would be great.

@willie-hung
Fix Contour typo
96dd0f2 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@willie-hung
Copy link
Contributor Author

@michael-s-molina Typo fix.

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7f8d11) 69.01% compared to head (96dd0f2) 69.17%.
Report is 178 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #25770      +/-   ##
==========================================
+ Coverage   69.01%   69.17%   +0.15%     
==========================================
  Files        1934     1944      +10     
  Lines       75605    75751     +146     
  Branches     8414     8460      +46     
==========================================
+ Hits        52181    52399     +218     
+ Misses      21264    21167      -97     
- Partials     2160     2185      +25
Flag Coverage Δ
javascript 56.51% <ø> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

michael-s-molina
michael-s-molina approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvements @willie-hung!

@michael-s-molina michael-s-molina merged commit 113a8a3 into apache:master Jan 3, 2024
30 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Ephemeral environment shutdown and build artifacts deleted.

@michael-s-molina michael-s-molina mentioned this pull request Jan 3, 2024
Closed
9 tasks
@michael-s-molina michael-s-molina added the v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch label Jan 3, 2024
michael-s-molina pushed a commit that referenced this pull request Jan 3, 2024
@willie-hung @michael-s-molina
chore: Add example charts for deck.gl (#25770)
c520cf4 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
(cherry picked from commit 113a8a3)
sivasathyaseeelan pushed a commit to sivasathyaseeelan/superset that referenced this pull request Jan 3, 2024
@willie-hung @sivasathyaseeelan
chore: Add example charts for deck.gl (apache#25770)
af29bd2 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@willie-hung willie-hung deleted the issue16707 branch January 4, 2024 03:41
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@willie-hung @josedev-union
chore: Add example charts for deck.gl (apache#25770)
ec745d5 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
(cherry picked from commit 113a8a3)
@mistercrunch mistercrunch added 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@willie-hung @sfirke
chore: Add example charts for deck.gl (apache#25770)
7675deb 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@willie-hung
chore: Add example charts for deck.gl (apache#25770)
74e4958 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.1.0 🍒 3.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@willie-hung @john-bodley @michael-s-molina @mistercrunch