Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removes border of the color picker control #25812

Merged
merged 1 commit into from
Nov 2, 2023
Merged

chore: Removes border of the color picker control #25812

merged 1 commit into from
Nov 2, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Removes the weird border of the color picker control to match its style with other popovers in the application.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-10-31 at 14 15 33 Screenshot 2023-10-31 at 16 05 25

TESTING INSTRUCTIONS

CI should be sufficient.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina mentioned this pull request Oct 31, 2023
Merged
9 tasks
kgabryje
kgabryje approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit aaf7d6b into apache:master Nov 2, 2023
27 checks passed
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@michael-s-molina
chore: Removes border of the color picker control (apache#25812)
e396a60
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@michael-s-molina @sfirke
chore: Removes border of the color picker control (apache#25812)
fc09038
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@michael-s-molina
chore: Removes border of the color picker control (apache#25812)
5adfae3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @kgabryje @mistercrunch