fix: add validation on tag name to have name + onDelete refresh list view #25831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
reviewed
Nov 2, 2023
| @@ -58,7 +58,7 @@ class TaggedObjectEntityResponseSchema(Schema): | |||
|
|
|||
|
|
|||
| class TagObjectSchema(Schema): | |||
| name = fields.String() | |||
| name = fields.String(validate=Length(min=1)) | |||
There was a problem hiding this comment.
Does this logic also need to reside within the Command or DAO? Additionally do we have any tests for schema validation?
There was a problem hiding this comment.
it lies in the API, I'm working on a test now to validate
hughhhh
changed the title
eschutho
reviewed
Nov 2, 2023
eschutho
reviewed
Nov 2, 2023
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…view (apache#25831) Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
mistercrunch
added
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
…view (apache#25831) Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
…view (apache#25831) Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
add validation on tag name to have name
bug in production that allows users to create tags without names. So we added validation to the schema to make sure the length of the tag name field is atleast 1.
fix reload callback after deleting tag
before hand the callback would execute before a tag would actually be deleted from the db. So fixed it the refresh to be called after success/failed request
Screen.Recording.2023-11-02.at.3.44.59.PM.mov
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION