fix(sqllab): table preview has gone #25977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
added
the
v3.1
michael-s-molina
pushed a commit
that referenced
this pull request
Dec 4, 2023
(cherry picked from commit cdbbd83)
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
(cherry picked from commit cdbbd83)
mistercrunch
added
🍒 3.1.0
🍒 3.1.1
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #25597
When a tab is switched, the onSchemaChange action trigger is redundantly triggered with the same schema value. This causes the current table selection reset as recognize the schema switches. (This typically happens in SQLLAB_BACKEND_PERSISTENCE mode due to the sequence of api updates)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--table-selection-persist.mov
After:
after--table-selection-persist.mov
TESTING INSTRUCTIONS
SET SQLLAB_BACKEND_PERSISTENCE True
Open a new tab and select one table
Add a new tab and then switch back to the previous tab
Verify if the table selection has been persisted
ADDITIONAL INFORMATION