-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move driver import to method #26066
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26066 +/- ##
=======================================
Coverage 69.09% 69.09%
=======================================
Files 1940 1940
Lines 75867 75867
Branches 8444 8444
=======================================
Hits 52423 52423
Misses 21268 21268
Partials 2176 2176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Accidentally imported a trino driver type at module-level, which can cause problems for users who don't have the trino driver installed.
2af4efb
to
805e665
Compare
I'll merge to fix the build - thanks for the prompt fix! - but can you explain the pylint comment to me for learning purposes? |
@sfirke pylint lints our python code and looks for bad practices, code smell, etc. Generally it's best practice for imports to be at the top of the file, but as we've seen here, that doesn't always work out for our use case. The comment tells pylint to disregard this one. |
SUMMARY
Accidentally imported a trino driver type at module-level, which can cause problems for users who don't have the trino driver installed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Run superset without the trino driver installed.
ADDITIONAL INFORMATION