fix(Embedded): Avoid creating a filter key for guest users #26312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michael-s-molina this is implementing your feedback from #25687. Let me know if you have any concerns or feedback! 🙏 🙇♂️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26312 +/- ##
=======================================
Coverage 69.18% 69.18%
=======================================
Files 1945 1945
Lines 75967 75984 +17
Branches 8467 8476 +9
=======================================
+ Hits 52556 52570 +14
Misses 21224 21224
- Partials 2187 2190 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
michael-s-molina
changed the title
michael-s-molina
added
v3.0
michael-s-molina
pushed a commit
that referenced
this pull request
Dec 27, 2023
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> (cherry picked from commit fe9fbad)
michael-s-molina
pushed a commit
that referenced
this pull request
Dec 27, 2023
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> (cherry picked from commit fe9fbad)
mistercrunch
added
🍒 3.0.3
🍒 3.0.4
🍒 3.1.0
🍒 3.1.1
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
…26312) Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
…26312) Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Dashboard filter combinations are persisted in Superset through a URL parameter. This functionality is currently not compatible with Embedded (the dashboard doesn't emit a generated filter key up to the application that could be re-used in a refresh) so this PR removes the logic to write a filter key for embedded users.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No UI changes.
TESTING INSTRUCTIONS
/api/v1/dashboard/{{DashboardID}}/filter_state?tab_id={{TabID}}isn't being fired.ADDITIONAL INFORMATION