-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adds a tooltip for the alert's SQL input #26317
chore: Adds a tooltip for the alert's SQL input #26317
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26317 +/- ##
=======================================
Coverage 69.18% 69.18%
=======================================
Files 1945 1945
Lines 75968 75970 +2
Branches 8467 8467
=======================================
+ Hits 52557 52559 +2
Misses 21224 21224
Partials 2187 2187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@michael-s-molina technically it doesn't need to be numeric, i.e., it could be a string, as we use the Python
While we're at it, should we also simply remove tooltip for the threshold value, given that it technically doesn't need to be a double precision number, e.g., an integer will work. It seems like the input box rejects non-numerical values (excluding the period) and thus the input in already sanitized. |
@john-bodley Applied your suggestions. |
(cherry picked from commit 5bd7fd7)
(cherry picked from commit 5bd7fd7)
(cherry picked from commit 5bd7fd7)
SUMMARY
It's not very clear that the SQL used to create an alert should return a numeric value. When non-numeric values are returned, the error
Alert query returned a non-number value
is thrown when firing the alert. This PR adds a tooltip for the alert's SQL input to instruct users in advance.Closes #26298
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
1 - Open the alert creation modal
2 - Check the displayed tooltip
ADDITIONAL INFORMATION