Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(accessibility): Enable tabbing on sort header of table chart #26326

Merged
merged 1 commit into from
Dec 23, 2023
Merged

fix(accessibility): Enable tabbing on sort header of table chart #26326

merged 1 commit into from
Dec 23, 2023

Conversation

arunthirumani
Copy link
Contributor

@arunthirumani arunthirumani commented Dec 21, 2023 •
edited
Loading

SUMMARY

  1. Add tabIndex attribute to 'th' tag in TableChart.tsx
  2. Add keyboard event handler to trigger column sorting when 'Action' key is pressed on sort header

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
before-fix

AFTER:
after-fix

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@arunthirumani arunthirumani mentioned this pull request Dec 21, 2023
Closed
3 tasks
github-actions[bot]
github-actions bot reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@arunthirumani arunthirumani changed the title fix(accessibility):Enable tabbing on header row of table chart [WIP] fix(accessibility):Enable tabbing on sort header of table chart [WIP] Dec 21, 2023
@arunthirumani arunthirumani changed the title fix(accessibility):Enable tabbing on sort header of table chart [WIP] fix(accessibility):Enable tabbing on sort header of table chart Dec 21, 2023
@arunthirumani arunthirumani changed the title fix(accessibility):Enable tabbing on sort header of table chart fix(accessibility): Enable tabbing on sort header of table chart Dec 21, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bf5b18c) 69.19% compared to head (0239046) 69.19%.
Report is 43 commits behind head on master.

Files Patch % Lines
...tend/plugins/plugin-chart-table/src/TableChart.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #26326   +/-   ##
=======================================
  Coverage   69.19%   69.19%           
=======================================
  Files        1944     1945    +1     
  Lines       75927    75962   +35     
  Branches     8451     8468   +17     
=======================================
+ Hits        52534    52559   +25     
- Misses      21208    21216    +8     
- Partials     2185     2187    +2
Flag Coverage Δ
javascript 56.51% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yousoph
Copy link
Member

yousoph commented Dec 21, 2023

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://54.191.47.44:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

eschutho
eschutho approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @arunthirumani

@eschutho
Copy link
Member

@yousoph I'll wait for you to 👍 on the UI changes before merging.

@yousoph yousoph merged commit b6d433d into apache:master Dec 23, 2023
35 of 39 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Dec 27, 2023
michael-s-molina pushed a commit that referenced this pull request Dec 27, 2023
@arunthirumani @michael-s-molina
fix(accessibility): Enable tabbing on sort header of table chart (#26326
643cb9d 
)

(cherry picked from commit b6d433d)
michael-s-molina pushed a commit that referenced this pull request Dec 27, 2023
@arunthirumani @michael-s-molina
fix(accessibility): Enable tabbing on sort header of table chart (#26326
b1b2b57 
)

(cherry picked from commit b6d433d)
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@arunthirumani @josedev-union
fix(accessibility): Enable tabbing on sort header of table chart (apa…
1be0bf5 
…che#26326)

(cherry picked from commit b6d433d)
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@arunthirumani @sfirke
fix(accessibility): Enable tabbing on sort header of table chart (apa…
0241ac4 
…che#26326)
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@arunthirumani
fix(accessibility): Enable tabbing on sort header of table chart (apa…
3b1aa95 
…che#26326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@eschutho eschutho eschutho approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arunthirumani @yousoph @eschutho @mistercrunch @michael-s-molina