-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Removes the deprecated CLIENT_CACHE feature flag #26348
refactor: Removes the deprecated CLIENT_CACHE feature flag #26348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26348 +/- ##
=======================================
Coverage 69.07% 69.07%
=======================================
Files 1931 1931
Lines 75329 75323 -6
Branches 8431 8429 -2
=======================================
- Hits 52030 52028 -2
+ Misses 21151 21148 -3
+ Partials 2148 2147 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@betodealmeida I thought you might be the ideal person to review this given you added the feature in #7348 likely to handle a specific use case for Lyft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
As part of the 4.0 approved initiatives, this PR removes the
CLIENT_CACHE
feature flag.The previous value of the feature flag was
False
and now the feature is permanently removed.TESTING INSTRUCTIONS
CI should be sufficient for merging this PR. We'll do a complete testing of 4.0 after all approved proposals are merged.
ADDITIONAL INFORMATION