Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrates legacy Sunburst charts to ECharts and removes legacy code #26350

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

As part of the 4.0 approved initiatives, this PR removes the legacy Sunburst chart by:

  • Removing old plugin references throughout the codebase
  • Updating unit tests
  • Updating E2E tests
  • Updating the example dashboards

TESTING INSTRUCTIONS

1 - Make sure all legacy Sunburst charts were converted to Sunburst v2
2 - Make sure legacy Sunburst is not available anymore in the viz picker

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added risk:breaking-change Issues or PRs that will introduce breaking changes hold! On hold v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch labels Dec 22, 2023
@michael-s-molina michael-s-molina force-pushed the remove-legacy-sunburst branch 2 times, most recently from f71c6ff to 0d01d57 Compare December 26, 2023 14:01
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf20b34) 69.06% compared to head (9c6ea29) 69.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26350      +/-   ##
==========================================
+ Coverage   69.06%   69.24%   +0.18%     
==========================================
  Files        1930     1924       -6     
  Lines       75275    75030     -245     
  Branches     8429     8427       -2     
==========================================
- Hits        51985    51954      -31     
+ Misses      21143    20929     -214     
  Partials     2147     2147              
Flag Coverage Δ
hive 53.59% <ø> (+0.02%) ⬆️
javascript 56.78% <ø> (+0.30%) ⬆️
mysql 77.81% <ø> (+0.04%) ⬆️
postgres 77.94% <ø> (+0.04%) ⬆️
presto 53.54% <ø> (+0.02%) ⬆️
python 82.74% <ø> (-0.01%) ⬇️
sqlite ?
unit 56.04% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina michael-s-molina marked this pull request as ready for review January 5, 2024 18:52
@john-bodley
Copy link
Member

john-bodley commented Jan 6, 2024

@michael-s-molina I was wondering if the title of the PR "refactor: Removes the legacy Sunburst chart" should be updated?

A non-informed reader may recoil thinking that you're simply removing the legacy chart, whereas in actuality you're actually migrating all their legacy charts to the ECharts equivalent and annexing all the legacy code.

@michael-s-molina michael-s-molina changed the title refactor: Removes the legacy Sunburst chart refactor: Migrates legacy Sunburst charts to ECharts and removes legacy code Jan 8, 2024
@michael-s-molina
Copy link
Member Author

michael-s-molina commented Jan 8, 2024

@michael-s-molina I was wondering if the title of the PR "refactor: Removes the legacy Sunburst chart" should be updated?

A non-informed reader may recoil thinking that you're simply removing the legacy chart, whereas in actuality you're actually migrating all their legacy charts to the ECharts equivalent and annexing all the legacy code.

Good callout. I changed the PR title to "refactor: Migrates legacy Sunburst charts to ECharts and removes legacy code"

@yousoph
Copy link
Member

yousoph commented Jan 11, 2024

Is Sunburst v2 going to be renamed to "Sunburst" in the viz picker since there will be only one?

@michael-s-molina michael-s-molina removed the hold! On hold label Jan 16, 2024
@michael-s-molina
Copy link
Member Author

Is Sunburst v2 going to be renamed to "Sunburst" in the viz picker since there will be only one?

@yousoph Good call. Renamed.

@michael-s-molina michael-s-molina merged commit 4d9144e into apache:master Jan 18, 2024
33 checks passed
Muhammed-baban pushed a commit to intellica-tech/reporting-tool that referenced this pull request Jan 19, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/XXL v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants