Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RLS modal styling #26634

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix: RLS modal styling #26634

merged 1 commit into from
Jan 16, 2024

Conversation

geido
Copy link
Member

@geido geido commented Jan 16, 2024

SUMMARY

The style of the RLS modal presented a few issues:

  • Info icons should be centered with the text horizontally
  • There should be the same spacing between the labels and inputs vertically
  • The colors of the labels should all be the same
  • The border color of the description field should be same as others

BEFORE

Screenshot 2024-01-16 at 17 20 21

AFTER

Screenshot 2024-01-16 at 17 16 15

TESTING INSTRUCTIONS

  1. Add a new rule in the Row Level Security settings
  2. Make sure the style of the modal is consistent with other modals in Superset

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ca6d8c) 69.18% compared to head (032316f) 69.18%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26634   +/-   ##
=======================================
  Coverage   69.18%   69.18%           
=======================================
  Files        1948     1948           
  Lines       76036    76030    -6     
  Branches     8478     8474    -4     
=======================================
- Hits        52604    52600    -4     
+ Misses      21265    21264    -1     
+ Partials     2167     2166    -1     
Flag Coverage Δ
hive 53.68% <ø> (ø)
mysql 78.04% <ø> (ø)
postgres 78.16% <ø> (ø)
presto 53.63% <ø> (ø)
python 82.86% <ø> (ø)
sqlite 77.76% <ø> (ø)
unit 55.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@geido geido merged commit 820f4b9 into master Jan 16, 2024
54 checks passed
@michael-s-molina michael-s-molina added v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch labels Jan 17, 2024
michael-s-molina pushed a commit that referenced this pull request Jan 18, 2024
michael-s-molina pushed a commit that referenced this pull request Jan 18, 2024
(cherry picked from commit 820f4b9)
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Feb 12, 2024
@mistercrunch mistercrunch added 🍒 3.0.4 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@rusackas rusackas deleted the diego/ch75507/fix-rls-modal-style branch April 16, 2024 16:51
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.4 🍒 3.1.1 🍒 3.1.2 🍒 3.1.3 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants