Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Period over Period Big Number comparison chart #26908

Merged
merged 7 commits into from
Jan 31, 2024
Merged

feat: Period over Period Big Number comparison chart #26908

merged 7 commits into from
Jan 31, 2024

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Jan 31, 2024 •
edited
Loading

SUMMARY

This is an experimental visualization using the feature flag CHART_PLUGINS_EXPERIMENTAL.
It is a period over period comparison chart for Big Number

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2024-01-30 at 20 34 23 (1)

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov Codecov
Copy link

codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

Attention: 138 lines in your changes are missing coverage. Please review.

Comparison is base (d8f7e2c) 67.29% compared to head (2ac04ea) 69.51%.
Report is 10 commits behind head on master.

Files Patch % Lines
...rt-period-over-period-kpi/src/plugin/buildQuery.ts 0.00% 99 Missing ⚠️
...eriod-over-period-kpi/src/plugin/transformProps.ts 3.70% 26 Missing ⚠️
...plugin-chart-period-over-period-kpi/src/PopKPI.tsx 0.00% 10 Missing ⚠️
...n-chart-period-over-period-kpi/src/plugin/index.ts 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #26908      +/-   ##
==========================================
+ Coverage   67.29%   69.51%   +2.21%     
==========================================
  Files        1895     1900       +5     
  Lines       74249    74347      +98     
  Branches     8257     8264       +7     
==========================================
+ Hits        49968    51680    +1712     
+ Misses      22206    20618    -1588     
+ Partials     2075     2049      -26
Flag Coverage Δ
hive 53.81% <ø> (?)
javascript 56.93% <2.12%> (-0.18%) ⬇️
mysql 77.95% <ø> (-0.03%) ⬇️
postgres 78.07% <ø> (-0.01%) ⬇️
presto 53.76% <ø> (?)
python 83.03% <ø> (+4.81%) ⬆️
sqlite 77.66% <ø> (-0.01%) ⬇️
unit 56.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eschutho
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Container image not yet published for this PR. Please try again when build is complete.

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Ephemeral environment creation failed. Please check the Actions logs for details.

Fernando and others added 5 commits January 31, 2024 16:28
@Antonio-RiveroMartnez
Period Over Period KPI plugin
f523739
@Antonio-RiveroMartnez
Period Over Period Plugin:
51b13f3 
- Fix format and lint
- Rewrite some functions to help with type checks
- Use css when possible in the Plugin component
@Antonio-RiveroMartnez
Period Over Period Plugin:
2c669ef 
- Add Feature Flag so experimental chart plugins are not available unless explicitly set to True
@eschutho @Antonio-RiveroMartnez
change name of plugin
d17fac8
@Antonio-RiveroMartnez
fix package-lock
1f17893
@eschutho
Copy link
Member Author

/testenv up

@eschutho eschutho marked this pull request as ready for review January 31, 2024 18:43
@github-actions GitHub Actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://54.149.104.195:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho
Copy link
Member Author

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://35.91.79.158:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

betodealmeida
betodealmeida approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the docs seems to be for a generic plugin, can we fix that?

superset-frontend/plugins/plugin-chart-period-over-period-kpi/README.md Outdated

# custom-viz

This is the Custom Viz Superset Chart Plugin.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this file is supposed to be a template for a generic custom visualization? Can we replace all references to "custom viz" with the actual names of the viz/file/class?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point 👍

@eschutho eschutho merged commit a09e555 into apache:master Jan 31, 2024
44 checks passed
@eschutho eschutho deleted the bytecode/time-shift branch January 31, 2024 23:44
@github-actions GitHub Actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@sadpandajoe
Copy link
Contributor

🏷️ preset:2024.5

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Feb 1, 2024
@eschutho @sadpandajoe
feat: Period over Period Big Number comparison chart (apache#26908)
ff490e7 
Co-authored-by: Fernando <frodriguez@bytecode.io>
Co-authored-by: Antonio Rivero <antonioriverocode@gmail.com>
(cherry picked from commit a09e555)
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@eschutho @Antonio-RiveroMartnez @sfirke
feat: Period over Period Big Number comparison chart (apache#26908)
038acda 
Co-authored-by: Fernando <frodriguez@bytecode.io>
Co-authored-by: Antonio Rivero <antonioriverocode@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

@Antonio-RiveroMartnez Antonio-RiveroMartnez Antonio-RiveroMartnez approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dependencies:npm size/XXL 🚢 4.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eschutho @sadpandajoe @betodealmeida @Antonio-RiveroMartnez @mistercrunch