Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): bump version number in docs example #27038

Merged

Conversation

sfirke
Copy link
Member

@sfirke sfirke commented Feb 7, 2024

SUMMARY

There are example version numbers in the Alerts & Reports docs listed as 2.0.1. At least one new user took this as a sign that this page was stale. It is not. I am bumping it to 3.1.0 to make that clearer.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Feb 7, 2024
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mistercrunch
Copy link
Member

mistercrunch commented Feb 8, 2024

Is there an easy way in docausurus "templatize" and use a variable like {{ latest_asf_version }} so that we could just bump in one place and add a note to bump this variable as part of the release process?

This look promising -> facebook/docusaurus#5700

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting to "Request changes" as otherwise it'll get stale or force us to grep + multi-update at every release... This also sets a new pattern to keep the docs more dynamic, worth doing if we can figure this out quickly.

@rusackas
Copy link
Member

rusackas commented Feb 8, 2024

I'm fine with letting this through and following up on a fancier version. For getting fancy, we need to differentiate between latest stable (i.e. not a major x.0.0) and latest, so doing it as part of the release process might not work the way we want.

We could make a little script as a "prebuild" step for docusaurus, so that whenever it builds, it scrapes GitHub (or Apache, potentially) for all the latest releases, and saves a little JSON object like :

{
  latest: 'x.x.x',
  latest_stable: 'x.x.x',
  latest_major: 'x.0.0',
  latest_minor: 'x.x.0',
  latest_patch: 'x.x.x',
  lts: 'x.x.x'
}

This could then be directly included in any MDX page to spit out whatever we want, perhaps via a React component like <VersionNumber release="latest_stable" />

@mistercrunch
Copy link
Member

Ok it's getting too fancy, do whatevs :)

@rusackas
Copy link
Member

rusackas commented Feb 8, 2024

We have a task board for Documentation. I'll put this idea on there for a rainy day :)

@rusackas rusackas merged commit c222464 into apache:master Feb 8, 2024
29 of 30 checks passed
sfirke added a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc Namespace | Anything related to documentation size/S 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants