feat(plugins): Update custom controls for BigNumber with Time Comparison chart #27054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move the Custom filters controls into the query section - Custom filter is visible only if Custom range is selected and if so it's required
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #27054 +/- ##
==========================================
- Coverage 67.19% 67.18% -0.01%
==========================================
Files 1899 1899
Lines 74369 74377 +8
Branches 8274 8276 +2
==========================================
+ Hits 49970 49971 +1
- Misses 22344 22351 +7
Partials 2055 2055
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/testenv up |
1 similar comment
|
/testenv up |
|
/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true |
|
@Antonio-RiveroMartnez Ephemeral environment spinning up at http://52.26.224.231:8080. Credentials are |
|
Ephemeral environment shutdown and build artifacts deleted. |
9 tasks
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Feb 12, 2024
…son chart (apache#27054) (cherry picked from commit 435cd27)
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In order to help users to navigate the new comparison controls of the plugin we are making the Custom time range part of the query section, also it's only visible if custom range is selected and if so, it's a required field.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2024-02-08.at.21.26.17.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION