Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gevent upgrade to 23.9.1 #27112

Merged
merged 3 commits into from
Feb 15, 2024
Merged

fix: gevent upgrade to 23.9.1 #27112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
305b9a8
fix: gevent upgrade to 23.9.1
dpgaspar Feb 14, 2024
a5c0034
add gevent as an extra requirement
dpgaspar Feb 15, 2024
8753ded
Merge branch 'master' into fix/gevent-upgrade
dpgaspar Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements/docker.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
# via
# -r requirements/base.in
# -r requirements/docker.in
gevent==22.10.2
gevent==23.9.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're bumping versions the bounds should be updated in setup.py as this ensures that the correct versions of gevent (or similar) will be installed irrespective of how people build Superset.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only included on docker, we have no references of gevent on setup.py

Copy link
Member

@villebro villebro Feb 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add gevent as an optional extras_require?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I don't think we interact or will colide with gevent in any way since it could be used with gunicorn. gunicorn does not set any upper boundaries so I'm doing the same

# via -r requirements/docker.in
psycopg2-binary==2.9.6
# via apache-superset
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ def get_git_sha() -> str:
"excel": ["xlrd>=1.2.0, <1.3"],
"firebird": ["sqlalchemy-firebird>=0.7.0, <0.8"],
"firebolt": ["firebolt-sqlalchemy>=1.0.0, <2"],
"gevent": ["gevent>=23.9.1"],
"gsheets": ["shillelagh[gsheetsapi]>=1.2.10, <2"],
"hana": ["hdbcli==2.4.162", "sqlalchemy_hana==0.4.0"],
"hive": [
Expand Down
Loading